Stop calling getButton() in ComponentWithBrowseButton #25
Conversation
There was a problem hiding this comment.
Cool! Have you confirmed that this works? Previously we were listening to the button and now the listener is attached to the text field. It seems like this will be triggered for text entry or clicks (which I don't think we want) but not for clicks on the browse button (which we do).
This API is marked to be removed from the API in the platform, see https://github.com/JetBrains/intellij-community/blob/master/platform/platform-api/src/com/intellij/openapi/ui/ComponentWithBrowseButton.java#L270
Yes, I validated that it works as intended. |
|
Cool. Thanks! Looking closer, the API is odd and as it happens (Not sure why they didn't stick to |
2 participants
This API is marked to be removed from the API in the platform, see https://github.com/JetBrains/intellij-community/blob/master/platform/platform-api/src/com/intellij/openapi/ui/ComponentWithBrowseButton.java#L270
This changes the output from the verifier from 4 usages of scheduled for removal API to 2 usages of scheduled for removal API